Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the get option contract endpoints #310

Merged
merged 6 commits into from
Nov 13, 2024
Merged

Add the get option contract endpoints #310

merged 6 commits into from
Nov 13, 2024

Conversation

nathanhack
Copy link
Contributor

@nathanhack nathanhack commented Nov 11, 2024 •
edited by gnvk
Loading

Fixes #309.

@nathanhack nathanhack mentioned this pull request Nov 11, 2024
Closed
@nathanhack
Copy link
Contributor Author

I figure this is a good starting point for a discussion.

@gnvk gnvk changed the title add GetOptionContracts & GetOptionContract Add the get option contract endpoints Nov 11, 2024
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/options.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest_test.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 11, 2024
View reviewed changes
alpaca/rest.go Show resolved Hide resolved
nathanhack
nathanhack commented Nov 11, 2024
View reviewed changes
Copy link
Contributor Author

@nathanhack nathanhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ready for another look.

gnvk
gnvk reviewed Nov 12, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 12, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 12, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 12, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 12, 2024
View reviewed changes
alpaca/rest.go Show resolved Hide resolved
gnvk
gnvk reviewed Nov 12, 2024
View reviewed changes
alpaca/rest.go Show resolved Hide resolved
@nathanhack
Copy link
Contributor Author

Should be good for another look.

gnvk
gnvk reviewed Nov 13, 2024
View reviewed changes
alpaca/rest_test.go Outdated Show resolved Hide resolved
gnvk
gnvk reviewed Nov 13, 2024
View reviewed changes
alpaca/rest.go Outdated Show resolved Hide resolved
gnvk
gnvk approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@gnvk gnvk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for your contribution @nathanhack !

@gnvk gnvk merged commit 4ca59cf into alpacahq:master Nov 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnvk gnvk gnvk approved these changes

@said-saifi said-saifi Awaiting requested review from said-saifi said-saifi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Option contracts endpoint
2 participants
@nathanhack @gnvk